Re: Duplicate 'use' for TestLib in 001_ssltests.pl - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Duplicate 'use' for TestLib in 001_ssltests.pl
Date
Msg-id CAB7nPqSP826Rge5fLw43EugW5knZOAhwwHJs9F7YitDKpTsGBA@mail.gmail.com
Whole thread Raw
In response to Duplicate 'use' for TestLib in 001_ssltests.pl  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: Duplicate 'use' for TestLib in 001_ssltests.pl  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On Fri, Jan 8, 2016 at 4:16 PM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> Hello, I noticed that 001_ssltests.pl uselessly (perhaps) imports
> TestLib twice. Is this intentional? The following change made no
> differences.
>
>
> diff --git a/src/test/ssl/t/001_ssltests.pl b/src/test/ssl/t/001_ssltests.pl
> index 9ce0cf3..cd38e45 100644
> --- a/src/test/ssl/t/001_ssltests.pl
> +++ b/src/test/ssl/t/001_ssltests.pl
> @@ -2,7 +2,6 @@ use strict;
>  use warnings;
>  use PostgresNode;
>  use TestLib;
> -use TestLib;
>  use Test::More tests => 38;
>  use ServerSetup;
>  use File::Copy;

Nice catch. Yes that's an oversight and should be removed.
-- 
Michael



pgsql-hackers by date:

Previous
From: amul sul
Date:
Subject: Re: Bug in MergeAttributesIntoExisting() function.
Next
From: Magnus Hagander
Date:
Subject: Re: Duplicate 'use' for TestLib in 001_ssltests.pl