Re: Duplicate 'use' for TestLib in 001_ssltests.pl - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Duplicate 'use' for TestLib in 001_ssltests.pl
Date
Msg-id CABUevEx0tE0=6=m5uAmgS2dmS2dpn8Z0qknPv90DDY6wN03nKg@mail.gmail.com
Whole thread Raw
In response to Re: Duplicate 'use' for TestLib in 001_ssltests.pl  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers


On Fri, Jan 8, 2016 at 8:37 AM, Michael Paquier <michael.paquier@gmail.com> wrote:
On Fri, Jan 8, 2016 at 4:16 PM, Kyotaro HORIGUCHI
<horiguchi.kyotaro@lab.ntt.co.jp> wrote:
> Hello, I noticed that 001_ssltests.pl uselessly (perhaps) imports
> TestLib twice. Is this intentional? The following change made no
> differences.
>
>
> diff --git a/src/test/ssl/t/001_ssltests.pl b/src/test/ssl/t/001_ssltests.pl
> index 9ce0cf3..cd38e45 100644
> --- a/src/test/ssl/t/001_ssltests.pl
> +++ b/src/test/ssl/t/001_ssltests.pl
> @@ -2,7 +2,6 @@ use strict;
>  use warnings;
>  use PostgresNode;
>  use TestLib;
> -use TestLib;
>  use Test::More tests => 38;
>  use ServerSetup;
>  use File::Copy;

Nice catch. Yes that's an oversight and should be removed.

Applied, thanks. 


--

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Duplicate 'use' for TestLib in 001_ssltests.pl
Next
From: Magnus Hagander
Date:
Subject: Re: Comment typo in port/atomics/arch-x86.h