Re: [HACKERS] Compiler warning in costsize.c - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] Compiler warning in costsize.c
Date
Msg-id CAB7nPqSOn4-GbrOYN2zZdW6ku9OrsWf8yW3dfUP5s-cYfdt-sA@mail.gmail.com
Whole thread Raw
Responses Re: [HACKERS] Compiler warning in costsize.c  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Tue, Apr 4, 2017 at 9:42 PM, Michael Paquier
<michael.paquier@gmail.com> wrote:
> On Wed, Apr 5, 2017 at 2:54 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> (I'm personally not that much in love with PG_USED_FOR_ASSERTS_ONLY,
>> because it tends to confuse pgindent.)
>
> I would be incline to just do that, any other solution I can think of
> is uglier than that.

Actually, no. Looking at this issue again the warning is triggered
because the Assert() clause is present in USE_ASSERT_CHECKING. So
instead of removing PG_USED_FOR_ASSERTS_ONLY, here is a more simple
patch that fixes the problem. No need to put the variable *rte within
ifdefs as well.
-- 
Michael

-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

Attachment

pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: [HACKERS] SCRAM authentication, take three
Next
From: Fabien COELHO
Date:
Subject: Re: [HACKERS] Undefined psql variables