Re: psql \watch versus \timing - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: psql \watch versus \timing
Date
Msg-id CAB7nPqSOi7wNghSPDYkNjYtc36wiHnGMJvXO6pRY4P8Tp4A9Bg@mail.gmail.com
Whole thread Raw
In response to Re: psql \watch versus \timing  (Bruce Momjian <bruce@momjian.us>)
Responses Re: psql \watch versus \timing
List pgsql-hackers
On Tue, Oct 14, 2014 at 4:49 AM, Bruce Momjian <bruce@momjian.us> wrote:
> On Thu, Sep  4, 2014 at 10:50:58PM +0900, Michael Paquier wrote:
>> On Thu, Sep 4, 2014 at 1:44 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> > On Thu, Aug 28, 2014 at 8:46 PM, Fujii Masao <masao.fujii@gmail.com> wrote:
>> >> Good catch. So I will remove start_xact code later.
>> > Attached patch removes start_xact from PSQLexec.
>> Nothing negative to say here :)
>> Patch simply removes the second argument of PSQLexec that was set to
>> the same value everywhere, aka false as noticed by Heikki. Comments
>> and code blocks related to this parameter are removed, and the code
>> compiles, passing check-world as well (just kicked the tests in case).
>
> Uh, where are we on this?  Should I commit it?
The patch cleaning up the dead code of psql could be clearly applied
now. For the feature itself not sure, it may be better to let
Fujii-san manage it.
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: missing tab-completion for relation options
Next
From: Bruce Momjian
Date:
Subject: Re: interval typmodout is broken