Re: Making tab-complete.c easier to maintain - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Making tab-complete.c easier to maintain
Date
Msg-id CAB7nPqSKK1DinEALv-00hhRJ740JhWVvHoanXzRsQpmJen=8BA@mail.gmail.com
Whole thread Raw
In response to Re: Making tab-complete.c easier to maintain  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Making tab-complete.c easier to maintain  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On Wed, Dec 30, 2015 at 11:21 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Michael Paquier wrote:
>
>> OK, here are new patches.
>> - 0001 switches a bunch of TailMatches to Matches. Do we want to care
>> about the case where a schema is created following by a bunch of
>> objects? I mean stuff like "CREATE SCHEMA hoge CREATE TABLE ..." where
>> the current completion would work fine. The performance gains seem
>> worth it compared to the number of people actually using it, the point
>> has just not been raised yet.
>
> I'd rather have the completion work for that case than get a few
> microseconds speedup.  As far as I recall, it's only four commands that
> must retain the old coding.

Fine for me this way.
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Additional role attributes && superuser review
Next
From: Bruce Momjian
Date:
Subject: Re: Revisiting pg_stat_statements and IN() (Was: Re: pg_stat_statements fingerprinting logic and ArrayExpr)