Re: Making tab-complete.c easier to maintain - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Making tab-complete.c easier to maintain
Date
Msg-id 20151230142118.GV58441@alvherre.pgsql
Whole thread Raw
In response to Re: Making tab-complete.c easier to maintain  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Making tab-complete.c easier to maintain  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Michael Paquier wrote:

> OK, here are new patches.
> - 0001 switches a bunch of TailMatches to Matches. Do we want to care
> about the case where a schema is created following by a bunch of
> objects? I mean stuff like "CREATE SCHEMA hoge CREATE TABLE ..." where
> the current completion would work fine. The performance gains seem
> worth it compared to the number of people actually using it, the point
> has just not been raised yet.

I'd rather have the completion work for that case than get a few
microseconds speedup.  As far as I recall, it's only four commands that
must retain the old coding.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Better detail logging for password auth failures
Next
From: Alvaro Herrera
Date:
Subject: Re: Patch: fix lock contention for HASHHDR.mutex