Re: Broken --dry-run mode in pg_rewind - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Broken --dry-run mode in pg_rewind
Date
Msg-id CAB7nPqRkgd2sc2JS_MYyz1ucdB=idB+o+M5c1LZgYjMKjufr1g@mail.gmail.com
Whole thread Raw
In response to Re: Broken --dry-run mode in pg_rewind  (Heikki Linnakangas <hlinnaka@iki.fi>)
Responses Re: Broken --dry-run mode in pg_rewind
List pgsql-hackers
On Fri, May 8, 2015 at 9:34 PM, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> On 05/08/2015 03:25 PM, Vladimir Borodin wrote:
>> Seems, that pg_rewind does not account --dry-run option properly. A simple
>> fix
>> for that is attached.
>
>
> No, the --dry-run takes effect later. It performs all the actions it
> normally would, including reading files from the source, except for actually
> writing anything in the target. See the dry-run checks in file_ops.c

Even if the patch sent is incorrect, shouldn't there be some process
bypass in updateControlFile() and createBackupLabel() in case of a
--dry-run?
-- 
Michael



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Broken --dry-run mode in pg_rewind
Next
From: Heikki Linnakangas
Date:
Subject: Re: Broken --dry-run mode in pg_rewind