Re: Broken --dry-run mode in pg_rewind - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: Broken --dry-run mode in pg_rewind
Date
Msg-id 554CAD4B.7080502@iki.fi
Whole thread Raw
In response to Broken --dry-run mode in pg_rewind  (Vladimir Borodin <root@simply.name>)
Responses Re: Broken --dry-run mode in pg_rewind  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 05/08/2015 03:25 PM, Vladimir Borodin wrote:
> Hi all.
>
> Seems, that pg_rewind does not account --dry-run option properly. A simple fix
> for that is attached.

No, the --dry-run takes effect later. It performs all the actions it 
normally would, including reading files from the source, except for 
actually writing anything in the target. See the dry-run checks in 
file_ops.c

- Heikki



pgsql-hackers by date:

Previous
From: Vladimir Borodin
Date:
Subject: Broken --dry-run mode in pg_rewind
Next
From: Michael Paquier
Date:
Subject: Re: Broken --dry-run mode in pg_rewind