Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list
Date
Msg-id CAB7nPqRkc_82HB8o4GOhxTu1EceDueQs1uR3_AR-rwwjsQxTqA@mail.gmail.com
Whole thread Raw
In response to Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list  (Peter Eisentraut <peter.eisentraut@2ndquadrant.com>)
Re: [COMMITTERS] pgsql: Remove extra comma at end of enum list  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Oct 25, 2016 at 6:59 AM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Fabien COELHO <coelho@cri.ensmp.fr> writes:
>>> An alternative that would be worth considering is to adopt a uniform
>>> rule of // for line-ending comments and /* for all other uses.
>
>> Why not. As far as comments are concerned, editors usually highlight them
>> in some color, and my eyes get used to the comment color, so the simpler &
>> shorter the better, really.
>
>>> We'd have to teach pgindent about that, and I dunno how hard that is.
>
>> Maybe it is enough to just to turn "/* no-nl */" to "// no-nl" in
>> pgindent's post_indent, but probably I'm too naïve:-)
>
> Well, IMO the point of making that change would be to buy an additional
> three characters of space for the comment before it wraps.  So I'd suspect
> that post-processing is too late.  But I've not looked into pgindent to
> see where the decisions are made exactly.

Well... Coming back to the subject, are there any recommendations from
committers? -std=c89 in CFLAGS does not seem to help much to detect
extra commas in enums, even if this has been added in C99.
--
Michael



pgsql-hackers by date:

Previous
From: Merlin Moncure
Date:
Subject: Re: emergency outage requiring database restart
Next
From: Peter Geoghegan
Date:
Subject: Re: Parallel tuplesort (for parallel B-Tree index creation)