Re: BUG #13814: missing command in psql autocompletion - Mailing list pgsql-bugs

From Michael Paquier
Subject Re: BUG #13814: missing command in psql autocompletion
Date
Msg-id CAB7nPqRUNPhh7h_uFeNtZKPd2J=hEwZXbYMn90kwoc8YqV8tRA@mail.gmail.com
Whole thread Raw
In response to BUG #13814: missing command in psql autocompletion  (johannes@selfnet.de)
List pgsql-bugs
On Mon, Dec 14, 2015 at 4:32 AM,  <johannes@selfnet.de> wrote:
> I'm pretty accustomed to the autocompletion feature of psql. Now, I found
> that altering the tablespace of a materialized view is not included in the
> autocompletion options:
>
> db=> ALTER MATERIALIZED VIEW mvname <tab>
>
> offers ALTER COLUMN, OWNER TO, RENAME TO and SET SCHEMA, but not SET as for
> tables. When manually entered, the autocompletion options are the same as if
> SET was entered as a command.

Yeah, it would be more portable to hint first to SET, and then match
with the other keywords, like WITHOUT, TABLESPACE, SCHEMA, etc. And
actually ALTER MATVIEW SET does not hint correctly as well. See for
example the patch attached that improves a bit the situation. Note
that "SET (" does not hint to the list of parameters, we may want to
add some more stuff for the equivalent portion in ALTER TABLE SET, not
sure that's worth it...
--
Michael

Attachment

pgsql-bugs by date:

Previous
From: johannes@selfnet.de
Date:
Subject: BUG #13814: missing command in psql autocompletion
Next
From: Heikki Linnakangas
Date:
Subject: Re: PQexec() hangs on OOM