Re: COPY (... tab completion - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: COPY (... tab completion
Date
Msg-id CAB7nPqRQvKxbrr1qnwxdz6FOkx_5ffQ3dySxffF_Af4o70J4Mw@mail.gmail.com
Whole thread Raw
In response to Re: COPY (... tab completion  (Andreas Karlsson <andreas@proxel.se>)
Responses Re: COPY (... tab completion  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Jan 19, 2016 at 8:00 PM, Andreas Karlsson <andreas@proxel.se> wrote:
> On 01/19/2016 07:55 AM, Michael Paquier wrote:
>>
>> +    /* If we have COPY BINARY, compelete with list of tables */
>> s/compelete/complete
>
> Fixed.
>
>> +    else if (TailMatches2("COPY|\\copy", "("))
>> +        COMPLETE_WITH_LIST7("SELECT", "TABLE", "VALUES", "INSERT",
>> "UPDATE", "DELETE", "WITH");
>> This one should be Matches, no?
>
> Yep, fixed.

Marked as ready for committer.

This patch makes me wonder: are we going to nuke the grammar "COPY [
BINARY ] table_name" at some point? This was used up to 7.3.
-- 
Michael



pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Re: COPY (... tab completion
Next
From: Michael Paquier
Date:
Subject: Re: Move PinBuffer and UnpinBuffer to atomics