Re: [REVIEW] Re: Compression of full-page-writes - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [REVIEW] Re: Compression of full-page-writes
Date
Msg-id CAB7nPqR4QnWS1bpJTvnRLi05Dm9zvaUO_TqUDsp-QONeFA1EYw@mail.gmail.com
Whole thread Raw
In response to Re: [REVIEW] Re: Compression of full-page-writes  (Rahila Syed <rahilasyed90@gmail.com>)
List pgsql-hackers
On Fri, Nov 28, 2014 at 1:30 PM, Rahila Syed <rahilasyed90@gmail.com> wrote:
> I have attached the changes separately as changes.patch.

Yes thanks.
FWIW, I noticed those things as well when going through the code again
this morning for my tests. Note as well that the declaration of
doPageCompression at the top of xlog.c was an integer while it should
have been a boolean.
Regards,
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: [REVIEW] Re: Compression of full-page-writes
Next
From: Michael Paquier
Date:
Subject: Re: Using pg_rewind for differential backup