Re: [BUGS] [PATCH] Fixed malformed error message on malformed SCRAM message. - Mailing list pgsql-bugs

On Mon, May 29, 2017 at 2:06 PM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> These messages look all wrong to me.

So your complain would be to do the following for each error message
that uses parenthesis to include details? Like that I suppose:
--- a/src/backend/libpq/auth-scram.c
+++ b/src/backend/libpq/auth-scram.c
@@ -283,11 +283,13 @@ pg_be_scram_exchange(void *opaq, char *input,
int inputlen,   if (inputlen == 0)       ereport(ERROR,               (errcode(ERRCODE_PROTOCOL_VIOLATION),
-                (errmsg("malformed SCRAM message (empty message)"))));
+                errmsg("malformed SCRAM message"),
+                errdetail("Empty message.")));   if (inputlen != strlen(input))       ereport(ERROR,
(errcode(ERRCODE_PROTOCOL_VIOLATION),
-                (errmsg("malformed SCRAM message (length mismatch)"))));
+                errmsg("malformed SCRAM message"),
+                errdetail("Length mismatch.")));
-- 
Michael


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs