Re: [BUGS] [PATCH] Fixed malformed error message on malformed SCRAMmessage. - Mailing list pgsql-bugs

From Alvaro Herrera
Subject Re: [BUGS] [PATCH] Fixed malformed error message on malformed SCRAMmessage.
Date
Msg-id 20170529210649.ayz5hnilprnggvut@alvherre.pgsql
Whole thread Raw
In response to Re: [BUGS] [PATCH] Fixed malformed error message on malformed SCRAM message.  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: [BUGS] [PATCH] Fixed malformed error message on malformed SCRAM message.  (Andres Freund <andres@anarazel.de>)
Re: [BUGS] [PATCH] Fixed malformed error message on malformed SCRAM message.  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-bugs
Michael Paquier wrote:
> On Mon, May 29, 2017 at 1:43 PM, Alvaro Herrera
> <alvherre@2ndquadrant.com> wrote:
> > Daniele Varrazzo wrote:
> >> Patch attached
> >
> > Uh, shouldn't the parenthical comment be errdetail()?
> 
> FWIW, this did not strike me as necessary for this one as well all the
> other error messages in auth-scram.c as the main error strings are
> short, and the extra information looked adapted as part of the main
> error message.

To me this sounds like you're uttering "beetlejuice" thrice to summon
the message-style police.

These messages look all wrong to me.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-bugs

pgsql-bugs by date:

Previous
From: Дмитрий Сергеевич
Date:
Subject: [BUGS] Danger
Next
From: s.bondarev@southbridge.ru
Date:
Subject: [BUGS] BUG #14678: PGDG Rhel6 repo contain packet for Rhel7 system