Re: Renaming more clearly SHA functions in pgcrypto/ - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Renaming more clearly SHA functions in pgcrypto/
Date
Msg-id CAB7nPqQFOf_p1W7v+A=zavM2HkzVHhewX_YNOtivMPLVMjqiHg@mail.gmail.com
Whole thread Raw
In response to Re: Renaming more clearly SHA functions in pgcrypto/  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Tue, Jul 5, 2016 at 2:09 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> Michael Paquier wrote:
>> Hi all,
>> (folks interested in that in CC)
>>
>> While looking at some facility in pgcrypto, I have noticed the stanza
>> created by 56f4478 to prevent conflicts with OpenSSL, like that:
>> +#define SHA256_Init pg_SHA256_Init
>> +#define SHA256_Update pg_SHA256_Update
>>
>> Wouldn't it be better to avoid that, and just rename all those
>> functions as pg_shaXX_foo?
>
> Sure.

OK, so I guess I'll get something into a shape like that.
-- 
Michael



pgsql-hackers by date:

Previous
From: Amit Langote
Date:
Subject: Re: Declarative partitioning
Next
From: Michael Paquier
Date:
Subject: Re: Password identifiers, protocol aging and SCRAM protocol