Re: Renaming more clearly SHA functions in pgcrypto/ - Mailing list pgsql-hackers

From Alvaro Herrera
Subject Re: Renaming more clearly SHA functions in pgcrypto/
Date
Msg-id 20160704170916.GA426299@alvherre.pgsql
Whole thread Raw
In response to Renaming more clearly SHA functions in pgcrypto/  (Michael Paquier <michael.paquier@gmail.com>)
Responses Re: Renaming more clearly SHA functions in pgcrypto/  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
Michael Paquier wrote:
> Hi all,
> (folks interested in that in CC)
> 
> While looking at some facility in pgcrypto, I have noticed the stanza
> created by 56f4478 to prevent conflicts with OpenSSL, like that:
> +#define SHA256_Init pg_SHA256_Init
> +#define SHA256_Update pg_SHA256_Update
> 
> Wouldn't it be better to avoid that, and just rename all those
> functions as pg_shaXX_foo?

Sure.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Andrew Borodin
Date:
Subject: Re: Re: GiST optimizing memmoves in gistplacetopage for fixed-size updates [PoC]
Next
From: Alvaro Herrera
Date:
Subject: Re: Re: GiST optimizing memmoves in gistplacetopage for fixed-size updates [PoC]