Re: 9.5: Better memory accounting, towards memory-bounded HashAgg - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: 9.5: Better memory accounting, towards memory-bounded HashAgg
Date
Msg-id CAB7nPqQAj3paSjZO00L4wwWx+rB37nBGhXuQQUoP46-tDck0RA@mail.gmail.com
Whole thread Raw
In response to Re: 9.5: Better memory accounting, towards memory-bounded HashAgg  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
List pgsql-hackers
On Thu, Jan 8, 2015 at 4:07 AM, Tomas Vondra
<tomas.vondra@2ndquadrant.com> wrote:
> which is IMHO obviously wrong, because that accounts only for the
> hashtable itself.
> In those cases the patch actually does no memory accounting and as
> hashcontext has no child contexts, there's no accounting overhead.
> [blah]

> So the performance drops 2x. With more groups, the performance impact is
> even worse.
Hmm. It seems that this patch is not there yet, so marking it as
returned with feedback, especially knowing that the patch is incorrect
by using hascontext as mentioned by Tomas.
-- 
Michael



pgsql-hackers by date:

Previous
From: Manuel Kniep
Date:
Subject: Re: segmentation fault in execTuples.c#ExecStoreVirtualTuple
Next
From: Michael Paquier
Date:
Subject: Re: Turning recovery.conf into GUCs