Re: [HACKERS] ICU support on Windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: [HACKERS] ICU support on Windows
Date
Msg-id CAB7nPqQAKGuSQCAYgp-_8eoxUnNY7ueUOsQ7Lj=fDSn4A-NcHg@mail.gmail.com
Whole thread Raw
In response to Re: [HACKERS] ICU support on Windows  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [HACKERS] ICU support on Windows  (Alvaro Herrera <alvherre@2ndquadrant.com>)
List pgsql-hackers
On Tue, Jun 13, 2017 at 3:13 AM, Alvaro Herrera
<alvherre@2ndquadrant.com> wrote:
> Ashutosh Sharma wrote:
>> > I noticed that this only works if you use the "Win32" download of ICU,
>> > because the "Win64" download uses "lib64" paths.  I'm not sure what the
>> > impact of this is in practice.
>>
>> Yes, that's right, Win64 download uses lib64 path and in my case i had
>> renamed lib64-> lib and bin64-> bin which i guess is not a right thing
>> to do. I think, we should allow Solution.pm to detect the platform and
>> make a decision on the library path accordingly. Attached patch does
>> that. Please have a look let me know your thoughts on this. Thanks.
>
> Uh, that's pretty odd.  Is it something libicu-specific?  Because I
> don't see any other occurrence of \lib64\ anywhere in the MSVC build
> scripts.

I do some low level packaging on Windows (libxml2, libxslt, etc.), and
the compilation code usually allows you to usually use the
installation paths you want. At the end using only lib/ looks more
generic to me, and I did the same renaming as Ashutosh after unzipping
their files. There is already "Program Files" and "Program Files
(x86)" to make such distinctions.
-- 
Michael



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [HACKERS] Transactional sequence stuff breaks pg_upgrade
Next
From: Bruce Momjian
Date:
Subject: Re: pgindent (was Re: [HACKERS] [COMMITTERS] pgsql: Preventivemaintenance in advance of pgindent run.)