Postgres Pro
Downloads
Home   >   mailing lists

Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended
Date
Msg-id CAB7nPqQ5XZd4AdbisXUyGGhsaOBM8Mk8BHK0uSB3XiPw5w-wiQ@mail.gmail.com
Whole thread Raw
In response to WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended  (Mark Dilger <mark@port25.com>)
Responses Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended  (Heikki Linnakangas <hlinnakangas@vmware.com>)
List pgsql-hackers
Tree view


On Thu, Dec 11, 2014 at 7:44 AM, Mark Dilger <mark@port25.com> wrote:
At line 1787 of outfuncs.c, the line:

        WRITE_UINT_FIELD(reltablespace)

should probably say

        WRITE_OID_FIELD(reltablespace)

since that variable is of type Oid, not uint32.
Granted, these two macros are interchangeable,
but they won't be if we ever move to 64-bit Oids.
For correctness you are right. Looks like you spent quite some time looking at that..
--
Michael

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Too strict check when starting from a basebackup taken off a standby
Next
From: Amit Kapila
Date:
Subject: Re: On partitioning