Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended - Mailing list pgsql-hackers

From Heikki Linnakangas
Subject Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended
Date
Msg-id 54895417.7010809@vmware.com
Whole thread Raw
In response to Re: WRITE_UINT_FIELD used where WRITE_OID_FIELD likely intended  (Michael Paquier <michael.paquier@gmail.com>)
List pgsql-hackers
On 12/11/2014 05:57 AM, Michael Paquier wrote:
> On Thu, Dec 11, 2014 at 7:44 AM, Mark Dilger <mark@port25.com> wrote:
>
>> At line 1787 of outfuncs.c, the line:
>>
>>          WRITE_UINT_FIELD(reltablespace)
>>
>> should probably say
>>
>>          WRITE_OID_FIELD(reltablespace)
>>
>> since that variable is of type Oid, not uint32.
>> Granted, these two macros are interchangeable,
>> but they won't be if we ever move to 64-bit Oids.
>>
> For correctness you are right. Looks like you spent quite some time looking
> at that..

Fixed, thanks.

- Heikki



pgsql-hackers by date:

Previous
From: Rahila Syed
Date:
Subject: Re: [REVIEW] Re: Compression of full-page-writes
Next
From: Thomas Reiss
Date:
Subject: Re: Casting issues with domains