Re: Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree) - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)
Date
Msg-id CAB7nPqQ1yp8aTU6GK+2OSE3Jzf1oBnRsoV1mvV=J1Ka=YmSACg@mail.gmail.com
Whole thread Raw
In response to Re: Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: Enforce creation of destination folders for source files in pg_regress (Was: pg_regress writes into source tree)  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Fri, Feb 20, 2015 at 5:50 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> On 1/14/15 11:31 PM, Michael Paquier wrote:
>> pg_regress will fail with test suites using only source files if the
>> destination folders do not exist in the code tree. This is annoying
>> because this forces to maintain empty folders sql/ and expected/ with
>> a .gitignore ignoring everything.
>
> We'd still need the .gitignore files somewhere.  Do you want to move
> them one directory up?

I am not sure I am getting what you are pointing to... For extensions
that already have non-empty sql/ and expected/, they should have their
own ignore entries as sql/.gitignore and expected/.gitignore. The
point of the patch is to simplify the code tree of extensions that
need to keep empty sql/ and expected/, for example to be able to run
regression tests after a fresh repository clone for example.
-- 
Michael



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: pg_dump gets attributes from tables in extensions
Next
From: Etsuro Fujita
Date:
Subject: Re: inherit support for foreign tables