Re: Fixup some appendStringInfo and appendPQExpBuffer calls - Mailing list pgsql-hackers

From David Rowley
Subject Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Date
Msg-id CAApHDvrxNTJw7VfAvf0vFkLPQApr1yWX0Rxw6GMKo=o=5MLZHw@mail.gmail.com
Whole thread Raw
In response to Re: Fixup some appendStringInfo and appendPQExpBuffer calls  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: Fixup some appendStringInfo and appendPQExpBuffer calls  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, 3 Jun 2021 at 16:17, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > There are quite a few other places in that file that should be using
> > DatumGetCString() instead of DatumGetPointer().
> > Should we fix those too for PG14?
>
> +1.  I'm surprised we are not getting compiler warnings.

I pushed a fix for this.

I did happen to find one other in mcv.c which dates back to 2019. I
was wondering if we should bother with that one since it's already out
there in PG13.

David

Attachment

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Asynchronous Append on postgres_fdw nodes.
Next
From: Masahiko Sawada
Date:
Subject: Re: Transactions involving multiple postgres foreign servers, take 2