Postgres Pro
Downloads
Home   >   mailing lists

Re: Fixup some appendStringInfo and appendPQExpBuffer calls - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Date
Msg-id 246592.1622693826@sss.pgh.pa.us
Whole thread Raw
In response to Re: Fixup some appendStringInfo and appendPQExpBuffer calls  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Re: Fixup some appendStringInfo and appendPQExpBuffer calls
List pgsql-hackers
Tree view 
David Rowley <dgrowleyml@gmail.com> writes:
> There are quite a few other places in that file that should be using
> DatumGetCString() instead of DatumGetPointer().
> Should we fix those too for PG14?

+1.  I'm surprised we are not getting compiler warnings.

            regards, tom lane

pgsql-hackers by date:

Previous
From: vignesh C
Date:
Subject: Re: locking [user] catalog tables vs 2pc vs logical rep
Next
From: David Rowley
Date:
Subject: Re: Fixup some appendStringInfo and appendPQExpBuffer calls