Re: Fixup some appendStringInfo and appendPQExpBuffer calls - Mailing list pgsql-hackers

From David Rowley
Subject Re: Fixup some appendStringInfo and appendPQExpBuffer calls
Date
Msg-id CAApHDvqPKwbUn8Z74BZrDmLoZzcP4s+LZTxNuUi3P3OxbieT1Q@mail.gmail.com
Whole thread Raw
In response to Re: Fixup some appendStringInfo and appendPQExpBuffer calls  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Thu, 3 Jun 2021 at 16:17, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> David Rowley <dgrowleyml@gmail.com> writes:
> > There are quite a few other places in that file that should be using
> > DatumGetCString() instead of DatumGetPointer().
> > Should we fix those too for PG14?
>
> +1.  I'm surprised we are not getting compiler warnings.

I've attached a patch to fix those.

I did end up getting in a little deeper than I'd have liked as I also
found a few typos along the way.

Also, going by my calendar, the copyright year was incorrect.

Tomas, any chance you could look over this?  I didn't really take the
time to understand the code, so some of my comment adjustments might
be incorrect.

David

Attachment

pgsql-hackers by date:

Previous
From: "Joel Jacobson"
Date:
Subject: Re: security_definer_search_path GUC
Next
From: Michael Paquier
Date:
Subject: Re: Alias collision in `refresh materialized view concurrently`