Re: pgsql: Add Result Cache executor node (take 2) - Mailing list pgsql-committers

From David Rowley
Subject Re: pgsql: Add Result Cache executor node (take 2)
Date
Msg-id CAApHDvrgt9ZKQghHBnNvvSwTb2EE5c6QF+uqa=740awcoJ1juQ@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Add Result Cache executor node (take 2)  (Andres Freund <andres@anarazel.de>)
List pgsql-committers
On Sat, 3 Apr 2021 at 09:47, Andres Freund <andres@anarazel.de> wrote:
> Since this commit I am seeing
>
> In file included from /home/andres/src/postgresql/src/include/postgres.h:46,
>                  from /home/andres/src/postgresql/src/backend/executor/nodeResultCache.c:67:
> /home/andres/src/postgresql/src/backend/executor/nodeResultCache.c: In function ‘entry_purge_tuples’:
> /home/andres/src/postgresql/src/backend/executor/nodeResultCache.c:290:27: warning: comparison of unsigned expression
in‘>= 0’ is always true [-Wtype-limits] 
>   290 |  Assert(rcstate->mem_used >= 0);
>       |                           ^~

Those were last-minute additions and seems not well thought through.
I've now removed them.

Thanks for the report.

David



pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Remove useless Asserts in Result Cache code
Next
From: Jaime Casanova
Date:
Subject: Re: pgsql: Add 'noError' argument to encoding conversion functions.