Re: Can we do something to help stop users mistakenly using force_parallel_mode? - Mailing list pgsql-hackers

From David Rowley
Subject Re: Can we do something to help stop users mistakenly using force_parallel_mode?
Date
Msg-id CAApHDvrT8eq0UwgetGtQE7XLC8HFN8weqembtvYxMVgtWbcnjQ@mail.gmail.com
Whole thread Raw
In response to Re: Can we do something to help stop users mistakenly using force_parallel_mode?  (John Naylor <john.naylor@enterprisedb.com>)
Responses Re: Can we do something to help stop users mistakenly using force_parallel_mode?
List pgsql-hackers
On Thu, 2 Feb 2023 at 01:24, John Naylor <john.naylor@enterprisedb.com> wrote:
>
>
> On Wed, Feb 1, 2023 at 6:41 PM David Rowley <dgrowleyml@gmail.com> wrote:
> >
> > I don't really share Laurenz's worry [2] about compatibility break
> > from renaming this GUC. I think the legitimate usages of this setting
> > are probably far more rare than the illegitimate ones. I'm not overly
> > concerned about renaming if it helps stop people from making this
> > mistake. I believe the current name is just too conveniently named and
> > that users are likely just to incorrectly assume it does exactly what
> > they want because what else could it possibly do?!
> >
> > I think something like debug_parallel_query is much less likely to be misused.
>
> +1 on both points.

I've attached a patch which does the renaming to debug_parallel_query.
I've made it so the old name can still be used.  This is only intended
to temporarily allow backward compatibility until buildfarm member
owners can change their configs to use debug_parallel_query instead of
force_parallel_mode.

David

Attachment

pgsql-hackers by date:

Previous
From: Jim Jones
Date:
Subject: Re: [PATCH] Add pretty-printed XML output option
Next
From: Tomas Vondra
Date:
Subject: Re: daitch_mokotoff module