Postgres Pro
Downloads
Home   >   mailing lists

Re: Remove useless GROUP BY columns considering unique index - Mailing list pgsql-hackers

From David Rowley
Subject Re: Remove useless GROUP BY columns considering unique index
Date
Msg-id CAApHDvrHyz5LjZnwbEYsfbixbrK5H7+hwHd=et1vrX6iMeyf3w@mail.gmail.com
Whole thread Raw
In response to Re: Remove useless GROUP BY columns considering unique index  (jian he <jian.universality@gmail.com>)
List pgsql-hackers
Tree view 
On Mon, 2 Dec 2024 at 17:22, jian he <jian.universality@gmail.com> wrote:
> regarding v10.
> you placed remove_useless_groupby_columns right after add_base_rels_to_query
> makes so much sense.
> so we can be safely use cached RelOptInfo->indexlist, RelOptInfo->notnullattnums
> overall it didn't find any issue.

Thanks for looking.

After a bit more adjustment, I've pushed both patches.

I felt it was best to have the commit that moved
remove_useless_groupby_columns also change the call site of that
function.

David

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: pg_createsubscriber TAP test wrapping makes command options hard to read.
Next
From: David Rowley
Date:
Subject: Re: Remove useless GROUP BY columns considering unique index