Re: shadow variables - pg15 edition - Mailing list pgsql-hackers

From David Rowley
Subject Re: shadow variables - pg15 edition
Date
Msg-id CAApHDvrCYoAGz9Wn=baR8xY01QJiWGNd6Nc_MTOqSoDT0pSP7A@mail.gmail.com
Whole thread Raw
In response to Re: shadow variables - pg15 edition  (Andres Freund <andres@anarazel.de>)
Responses Re: shadow variables - pg15 edition  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Thu, 6 Oct 2022 at 13:39, Andres Freund <andres@anarazel.de> wrote:
> I attached a patch to add -Wshadow=compatible-local to our set of warnings.

Since I just committed the patch to fix the final warnings, I think we
should go ahead and commit the patch you wrote to add
-Wshadow=compatible-local to the standard build flags. I don't mind
doing this.

Does anyone think we shouldn't do it? Please let it be known soon.

David



pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Avoid mix char with bool type in comparisons
Next
From: Andres Freund
Date:
Subject: Re: meson: Add support for building with precompiled headers