Postgres Pro
Downloads
Home   >   mailing lists

Re: Avoid mix char with bool type in comparisons - Mailing list pgsql-hackers

From Tom Lane
Subject Re: Avoid mix char with bool type in comparisons
Date
Msg-id 3027732.1665102083@sss.pgh.pa.us
Whole thread Raw
In response to Re: Avoid mix char with bool type in comparisons  (Ranier Vilela <ranier.vf@gmail.com>)
Responses Re: Avoid mix char with bool type in comparisons  (Ranier Vilela <ranier.vf@gmail.com>)
List pgsql-hackers
Tree view 
Ranier Vilela <ranier.vf@gmail.com> writes:
> My main concerns is this point:
>   /* If already matched on earlier page, do no extra work */
> - if (key->entryRes[j])
> + if (key->entryRes[j] == GIN_TRUE)
>   continue;

> If GIN_MAYBE cases are erroneously ignored.

So, if that's a bug, you should be able to produce a test case?

            regards, tom lane

pgsql-hackers by date:

Previous
From: Ranier Vilela
Date:
Subject: Re: Avoid mix char with bool type in comparisons
Next
From: David Rowley
Date:
Subject: Re: shadow variables - pg15 edition