Re: pgsql: Improve PQtrace() output format - Mailing list pgsql-committers

From David Rowley
Subject Re: pgsql: Improve PQtrace() output format
Date
Msg-id CAApHDvrCReKezLJa1TFpbdyhRkz09j2Yib3Pro5XkdAOiVHJfg@mail.gmail.com
Whole thread Raw
In response to Re: pgsql: Improve PQtrace() output format  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-committers
On Tue, 6 Apr 2021 at 17:21, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> I wrote:
> > As best I can tell from these warnings, VS has the tv_sec field
> > of struct timeval defined as something other than time_t.  Because
> > VS would never stoop to actually complying with the plain text of
> > the POSIX standard.
>
> Ah, seems like it's really Winsock's fault:
>
> https://docs.microsoft.com/en-us/windows/win32/api/winsock/ns-winsock-timeval

Yeah. Thanks for having a look.  I pushed the fix with a comment
explaining why we bother with the local variable.

David



pgsql-committers by date:

Previous
From: David Rowley
Date:
Subject: pgsql: Fix compiler warning in fe-trace.c for MSVC
Next
From: Amit Kapila
Date:
Subject: Re: pgsql: Allow pgoutput to send logical decoding messages.