Re: Use generation memory context for tuplestore.c - Mailing list pgsql-hackers

From David Rowley
Subject Re: Use generation memory context for tuplestore.c
Date
Msg-id CAApHDvqg7oB+2e0nsQf9iSVYbrs=bZ0t8yvJ8M3F7d2cQFCRAQ@mail.gmail.com
Whole thread Raw
In response to Re: Use generation memory context for tuplestore.c  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
On Wed, 3 Jul 2024 at 22:41, David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Wed, 3 Jul 2024 at 00:20, Matthias van de Meent
> > Lastly, I think this would benefit from a test in
> > regress/sql/explain.sql, as the test changes that were included
> > removed the only occurrance of a Materialize node from the regression
> > tests' EXPLAIN outputs.
>
> I've modified the tests where the previous patch disabled
> enable_material to enable it again and mask out the possibly unstable
> part. Do you think that's an ok level of testing?

I spent quite a bit more time today looking at these patches. Mostly
that amounted to polishing comments more.

I've pushed them both now.

Thank you both of you for reviewing these.

David



pgsql-hackers by date:

Previous
From: Amit Kapila
Date:
Subject: Re: walsender.c comment with no context is hard to understand
Next
From: Dilip Kumar
Date:
Subject: Re: Conflict Detection and Resolution