Postgres Pro
Downloads
Home   >   mailing lists

Re: Add bump memory context type and use it for tuplesorts - Mailing list pgsql-hackers

From David Rowley
Subject Re: Add bump memory context type and use it for tuplesorts
Date
Msg-id CAApHDvqGiw6f=Mtt9EsnQL5_u8GxACjTNQ7YQ+cAy3JLkOTWqQ@mail.gmail.com
Whole thread Raw
In response to Re: Add bump memory context type and use it for tuplesorts  (Andres Freund <andres@anarazel.de>)
List pgsql-hackers
Tree view 
On Mon, 8 Apr 2024 at 09:09, Andres Freund <andres@anarazel.de> wrote:
> I suspect that KeeperBlock() isn't returning true, because IsKeeperBlock misses
> the MAXALIGN(). I think that about fits with:

Thanks for investigating that.

I've just pushed a fix for the macro and also adjusted a location
which was *correctly* calculating the keeper block address manually to
use the macro. If I'd used the macro there to start with the Assert
likely wouldn't have failed, but there'd have been memory alignment
issues.

David

pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: Add bump memory context type and use it for tuplesorts
Next
From: John Naylor
Date:
Subject: Re: [PoC] Improve dead tuple storage for lazy vacuum