Re: [PATCH] Add min/max aggregate functions to BYTEA - Mailing list pgsql-hackers

From David Rowley
Subject Re: [PATCH] Add min/max aggregate functions to BYTEA
Date
Msg-id CAApHDvq-PaDK+NWcG4yhCFcQtvD8WzjzGO3WzJjM7GQREA5tYQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add min/max aggregate functions to BYTEA  (Marat Bukharov <marat.buharov@gmail.com>)
List pgsql-hackers
On Thu, 25 Jul 2024 at 02:42, Marat Bukharov <marat.buharov@gmail.com> wrote:
> V5 patch. I've added more tests with different bytea sizes

I just glanced over this patch. Are you still planning on working on
it? There's been no adjustments made since the last feedback you got
in early August.

Can you address Andrey's feedback on point #1?

Also, for bytea_larger() and bytea_smaller(), I suggest copying what's
been done in record_larger() and record_smaller() except use
byteacmp(). That'll remove all the duplicated code.

If you fix those up, I see no reason not to commit the patch.

David



pgsql-hackers by date:

Previous
From: jian he
Date:
Subject: Re: Statistics Import and Export
Next
From: David Rowley
Date:
Subject: Re: Increase of maintenance_work_mem limit in 64-bit Windows