> On Tue, 2013-09-17 at 15:13 +0500, Asif Naeem wrote: > > I did put some time review the patch, please see my findings below > > i.e. > > Updated patch for this.
This commit is has broken the visual studios windows build. I'm looking into it now
Looks like something like:
#ifndef WIN32
#define HAVE_VA_COPY 1
#endif
would need to be added to asprintf.c, but also some work needs to be done with mcxt.c as it uses va_copy unconditionally. Perhaps just defining a macro for va_copy would be better for windows. I was not quite sure the best header file for such a macro so I did not write a patch to fix it.
libpgport.lib(asprintf.obj) : error LNK2019: unresolved external symbol _va_copy referenced in function _vasprintf [D:\Postgres\c\pg_archivecleanup.vcxproj]
