Postgres Pro
Downloads
Home   >   mailing lists

Re: [PATCH] Add use of asprintf() - Mailing list pgsql-hackers

From David Rowley
Subject Re: [PATCH] Add use of asprintf()
Date
Msg-id CAApHDvpTVgOqM8J9N1hibo0oHX_W82jfNhiig8QqxQTfgdmdtQ@mail.gmail.com
Whole thread Raw
In response to Re: [PATCH] Add use of asprintf()  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: [PATCH] Add use of asprintf()  (David Rowley <dgrowleyml@gmail.com>)
List pgsql-hackers
Tree view
On Sat, Oct 12, 2013 at 2:58 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
Peter Eisentraut escribió:
> On Tue, 2013-09-17 at 15:13 +0500, Asif Naeem wrote:
> > I did put some time review the patch, please see my findings below
> > i.e.
>
> Updated patch for this.

Looks good to me.



This commit is has broken the visual studios windows build. I'm looking into it now
 
31 errors similar to:

"D:\Postgres\c\pgsql.sln" (default target) (1) ->
"D:\Postgres\c\pg_archivecleanup.vcxproj" (default target) (56) ->
  libpgport.lib(asprintf.obj) : error LNK2019: unresolved external symbol _va_copy referenced in function _vasprintf [D:\Postgres\c\pg_archivecleanup.vcxproj]
  .\Release\pg_archivecleanup\pg_archivecleanup.exe : fatal error LNK1120: 1 unresolved externals [D:\Postgres\c\pg_archivecleanup.vcxproj]

Regards

David Rowley


--
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services


--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers

pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Planner issue
Next
From: mohsen soodkhah mohammadi
Date:
Subject: using testlo example of postgres source code