Re: Incorrect comment regarding command completion tags - Mailing list pgsql-hackers

From David Rowley
Subject Re: Incorrect comment regarding command completion tags
Date
Msg-id CAApHDvp4s6p4qfrwX0XkJX93_H9O1yUYD6DTF9v+-NOfKzsdNg@mail.gmail.com
Whole thread Raw
In response to Re: Incorrect comment regarding command completion tags  (Mark Dilger <mark.dilger@enterprisedb.com>)
List pgsql-hackers
On Fri, 14 Oct 2022 at 11:38, Mark Dilger <mark.dilger@enterprisedb.com> wrote:
>
> > On Oct 13, 2022, at 2:56 PM, David Rowley <dgrowleyml@gmail.com> wrote:
> > In the attached, I rewrote the comment to remove mention of the
> > Asserts. I also tried to form the comment in a way that's more
> > understandable about why we always write a "0" in "INSERT 0 <nrows>".
>
> Your wording is better.  +1

Thanks for having a look. I adjusted the wording slightly as I had
written "ancient" in regards to PostgreSQL 11 and earlier.  It's
probably a bit early to call a supported version of PostgreSQL ancient
so I just decided to mention the version number instead.

I pushed the resulting patch.

Thanks for having a look.

David



pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: New "single-call SRF" APIs are very confusingly named
Next
From: Michael Paquier
Date:
Subject: Re: Support tls-exporter as channel binding for TLSv1.3