Postgres Pro
Downloads
Home   >   mailing lists

Re: Patch to improve a few appendStringInfo* calls - Mailing list pgsql-hackers

From David Rowley
Subject Re: Patch to improve a few appendStringInfo* calls
Date
Msg-id CAApHDvowoTudFXde8tYPZ_4ihFyXxXN1qyO-9grL9z87dUaERA@mail.gmail.com
Whole thread Raw
In response to Re: Patch to improve a few appendStringInfo* calls  (Peter Eisentraut <peter_e@gmx.net>)
Responses Re: Patch to improve a few appendStringInfo* calls  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
Tree view
On 12 May 2015 at 12:57, Peter Eisentraut <peter_e@gmx.net> wrote:
On 4/11/15 6:25 AM, David Rowley wrote:
> I've attached a small patch which just fixes a few appendStringInfo*
> calls that are not quite doing things the way that it was intended.

done


Thank you for pushing.

Shortly after I sent the previous patch I did a few more searches and also found some more things that are not quite right.
Most of these are to use the binary append method when the length of the string is already known.
There's also some fixes in there for appendPQExpBufferStr too.

I've re-based the patch and attached here.

Regards

David Rowley
Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Multixid hindsight design
Next
From: Dave Page
Date:
Subject: Re: proposal: contrib module - generic command scheduler