Re: Patch to improve a few appendStringInfo* calls - Mailing list pgsql-hackers

From Peter Eisentraut
Subject Re: Patch to improve a few appendStringInfo* calls
Date
Msg-id 5567B7F5.7050705@gmx.net
Whole thread Raw
In response to Re: Patch to improve a few appendStringInfo* calls  (David Rowley <dgrowleyml@gmail.com>)
Responses Re: Patch to improve a few appendStringInfo* calls  (David Rowley <david.rowley@2ndquadrant.com>)
List pgsql-hackers
On 5/12/15 4:33 AM, David Rowley wrote:
> Shortly after I sent the previous patch I did a few more searches and
> also found some more things that are not quite right.
> Most of these are to use the binary append method when the length of the
> string is already known.

For these cases it might be better to invent additional functions such
as stringinfo_to_text() and appendStringInfoStringInfo() instead of
repeating the pattern of referring to data and length separately.



pgsql-hackers by date:

Previous
From: Noah Misch
Date:
Subject: Re: RFC: Non-user-resettable SET SESSION AUTHORISATION
Next
From: Noah Misch
Date:
Subject: Re: pg_upgrade resets timeline to 1