Re: Unaccent extension python script Issue in Windows - Mailing list pgsql-hackers

From Hugh Ranalli
Subject Re: Unaccent extension python script Issue in Windows
Date
Msg-id CAAhbUMM+=hG0O0PCTu_m9vfdBgQtaUOnD=9UPt_zxQF0U_4oRQ@mail.gmail.com
Whole thread Raw
In response to Re: Unaccent extension python script Issue in Windows  (Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>)
Responses Re: Unaccent extension python script Issue in Windows
List pgsql-hackers

On Mon, 18 Mar 2019 at 01:14, Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp> wrote:
This patch contains irrelevant changes. The minimal required
change would be the attached. If you want refacotor the
UnicodeData reader or rearrange import sutff, it should be
separate patches.
I'm not sure I'd classify the second change as "irrelevant." Using "with" is the standard and recommended practice for working with files in Python. At the moment the script does nothing to close the open data file, whether through regular processing or in the case of an exception. I would argue that's a bug and should be fixed. Creating a separate patch for that seems to be adding work for no reason.

Hugh

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: pg_basebackup ignores the existing data directory permissions
Next
From: Robert Haas
Date:
Subject: Re: pg_basebackup ignores the existing data directory permissions