Re: psql \watch 2nd argument: iteration count - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: psql \watch 2nd argument: iteration count
Date
Msg-id CAAhFRxiVgm7jzcmMAekMqr61QBEfh=QtTTi=fDis3Ji0oetFug@mail.gmail.com
Whole thread Raw
In response to Re: psql \watch 2nd argument: iteration count  (Kyotaro Horiguchi <horikyota.ntt@gmail.com>)
Responses Re: psql \watch 2nd argument: iteration count  (Nathan Bossart <nathandbossart@gmail.com>)
List pgsql-hackers
Thanks for looking into this!

On Mon, Feb 20, 2023 at 6:15 PM Kyotaro Horiguchi
<horikyota.ntt@gmail.com> wrote:
>
>  FWIW the patch still accepts an incorrect parameter '1abc'
> by ignoring any trailing garbage.
Indeed, fixed.
>
> In any case, I reckon the error message should be more specific. In
> other words, it would be better if it suggests the expected input
> format and range.
+1.
Not a range, actually, because upper limits have no sense for a user.

>
> Regarding the second patch, if we want \watch to throw an error
> message for the garbage trailing to sleep times, I think we should do
> the same for iteration counts.
+1, done.

> Additionally, we need to update the
> documentation.
Done.

Thanks for the review!

Best regards, Andrey Borodin.

Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: Add LZ4 compression in pg_dump
Next
From: Michael Paquier
Date:
Subject: Re: [PATCH] fix msvc build libpq error LNK2019 when link openssl;