Re: Small patch to fix build on Windows - Mailing list pgsql-hackers

From Dmitry Igrishin
Subject Re: Small patch to fix build on Windows
Date
Msg-id CAAfz9KMYR2TAbbo1HeNBOS6w8ekz3fMZdKUFUa-9nrf20J+J8Q@mail.gmail.com
Whole thread Raw
In response to Re: Small patch to fix build on Windows  (Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>)
List pgsql-hackers
ср, 7 авг. 2019 г. в 15:33, Juan José Santamaría Flecha
<juanjo.santamaria@gmail.com>:
>
> On Wed, Aug 7, 2019 at 11:11 AM Dmitry Igrishin <dmitigr@gmail.com> wrote:
> >
> > ср, 7 авг. 2019 г. в 11:29, Kyotaro Horiguchi <horikyota.ntt@gmail.com>:
> > >
> > > Solution.pm has the following line:
> > >
> > > >       my $opensslcmd =
> > > >         $self->{options}->{openssl} . "\\bin\\openssl.exe version 2>&1";
> > >
> > > AFAICS that's all.
> > Thank you! The attached 2nd version of the patch fixes this too.
> >
>
> At some point the propossed patch for opensslcmd was like:
>
> + my $opensslprog = '\bin\openssl.exe version 2>&1';
> + my $opensslcmd = '"' . $self->{options}->{openssl} . '"' . $opensslprog;
>
> It can be a question of taste, but I think the dot is easier to read.
Well, the style inconsistent anyway, for example, in file Project.pm

$self->{def}      = "./__CFGNAME__/$self->{name}/$self->{name}.def";
$self->{implib}   = "__CFGNAME__/$self->{name}/$libname";

So, I don't know what style is preferable. Personally, I don't care.



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: stress test for parallel workers
Next
From: Peter Eisentraut
Date:
Subject: Unix-domain socket support on Windows