Re: Small patch to fix build on Windows - Mailing list pgsql-hackers

From Juan José Santamaría Flecha
Subject Re: Small patch to fix build on Windows
Date
Msg-id CAC+AXB3v52LiNSjZ5TbRwsxGshVsYmokUzfNwnzFXtLf4UHd2Q@mail.gmail.com
Whole thread Raw
In response to Re: Small patch to fix build on Windows  (Dmitry Igrishin <dmitigr@gmail.com>)
Responses Re: Small patch to fix build on Windows
List pgsql-hackers
On Wed, Aug 7, 2019 at 11:11 AM Dmitry Igrishin <dmitigr@gmail.com> wrote:
>
> ср, 7 авг. 2019 г. в 11:29, Kyotaro Horiguchi <horikyota.ntt@gmail.com>:
> >
> > Solution.pm has the following line:
> >
> > >       my $opensslcmd =
> > >         $self->{options}->{openssl} . "\\bin\\openssl.exe version 2>&1";
> >
> > AFAICS that's all.
> Thank you! The attached 2nd version of the patch fixes this too.
>

At some point the propossed patch for opensslcmd was like:

+ my $opensslprog = '\bin\openssl.exe version 2>&1';
+ my $opensslcmd = '"' . $self->{options}->{openssl} . '"' . $opensslprog;

It can be a question of taste, but I think the dot is easier to read.

Regards,

Juan José Santamaría Flecha



pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Grouping isolationtester tests in the schedule
Next
From: Peter Eisentraut
Date:
Subject: initdb: Use varargs macro for PG_CMD_PRINTF