Re: Small patch to fix build on Windows - Mailing list pgsql-hackers

From Dmitry Igrishin
Subject Re: Small patch to fix build on Windows
Date
Msg-id CAAfz9KMKPqFEcxb3wdFJpEmEdcfr-OYZWuj6xm8udSw=Oy0B5A@mail.gmail.com
Whole thread Raw
In response to Re: Small patch to fix build on Windows  (Alvaro Herrera <alvherre@2ndquadrant.com>)
Responses Re: Small patch to fix build on Windows  (Michael Paquier <michael@paquier.xyz>)
List pgsql-hackers
чт, 8 авг. 2019 г. в 20:07, Alvaro Herrera <alvherre@2ndquadrant.com>:
>
> On 2019-Aug-08, Dmitry Igrishin wrote:
>
> >               my $prefixcmd =
> > -               $solution->{options}->{python} . "\\python -c \"$pythonprog\"";
> > +               "\"$solution->{options}->{python}\\python\" -c \"$pythonprog\"";
>
> I think you can make this prettier like this:
>
>    my $prefixcmd = qq{"$solution->{options}->{python}\\python" -c "$pythonprog"};
This looks nice for a Perl hacker :-). As for me, it looks unusual and
a bit confusing. I never
programmed in Perl, but I was able to quickly understand where the
problem lies due to the
 style adopted in other languages, when the contents are enclosed in
quotation marks, and
the quotation marks are escaped if they are part of the contents.
So, should I fix it? Any thoughts?



pgsql-hackers by date:

Previous
From: Stephen Frost
Date:
Subject: Re: [Proposal] Table-level Transparent Data Encryption (TDE) and KeyManagement Service (KMS)
Next
From: Mark G
Date:
Subject: Re: Small const correctness patch