Re: Small patch to fix build on Windows - Mailing list pgsql-hackers

From Michael Paquier
Subject Re: Small patch to fix build on Windows
Date
Msg-id 20190809024517.GF3194@paquier.xyz
Whole thread Raw
In response to Re: Small patch to fix build on Windows  (Dmitry Igrishin <dmitigr@gmail.com>)
Responses Re: Small patch to fix build on Windows  (Dmitry Igrishin <dmitigr@gmail.com>)
List pgsql-hackers
On Thu, Aug 08, 2019 at 10:46:07PM +0300, Dmitry Igrishin wrote:
> This looks nice for a Perl hacker :-). As for me, it looks unusual and
> a bit confusing. I never
> programmed in Perl, but I was able to quickly understand where the
> problem lies due to the
>  style adopted in other languages, when the contents are enclosed in
> quotation marks, and
> the quotation marks are escaped if they are part of the contents.
> So, should I fix it? Any thoughts?

FWIW, I like Alvaro's suggestion about qq{} in this case, as it makes
sure that double-quotes are correctly applied where they should.
--
Michael

Attachment

pgsql-hackers by date:

Previous
From: Sehrope Sarkuni
Date:
Subject: Re: [Proposal] Table-level Transparent Data Encryption (TDE) and KeyManagement Service (KMS)
Next
From: Michael Paquier
Date:
Subject: Re: Add "password_protocol" connection parameter to libpq