Re: Nicer error when connecting to standby with hot_standby=off - Mailing list pgsql-hackers

From James Coleman
Subject Re: Nicer error when connecting to standby with hot_standby=off
Date
Msg-id CAAaqYe_E1_gdQZp8JvTGskpuq_uXvRMFhUTK8oBK4RWv4F7+_A@mail.gmail.com
Whole thread Raw
In response to Re: Nicer error when connecting to standby with hot_standby=off  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Tue, Mar 23, 2021 at 12:34 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > However, for this one
>
> > +       case CAC_NOTCONSISTENT:
> > +           if (EnableHotStandby)
> > +               ereport(FATAL,
> > +                       (errcode(ERRCODE_CANNOT_CONNECT_NOW),
> > +                        errmsg("the database system is not accepting connections"),
> > +                        errdetail("Consistent recovery state has not been yet reached.")));
>
> > Maybe it makes sense to say "... is not accepting connections *yet*".
>
> +1, but I think "... is not yet accepting connections" is slightly
> better style.

All right, see attached v8.

James Coleman

Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: making update/delete of inheritance trees scale better
Next
From: Pavel Stehule
Date:
Subject: Re: new release pspg