Dear Kuroda-san,
Thank you for your feedback and suggestions.
> To confirm, the top-right was generated with the previous patch, and bottom-right was generated v2 patch, right? I
preferthe bottom-right one.
Yes, your understanding is correct. The top-right image was generated
with the previous patch, and the bottom-right with the v2 patch.
Thank you also for your advice regarding splitting the patch into two parts:
- 0001: Set both body.start.indent and body.end.indent to 0
- 0002: Set margin-left and margin-right to 0.25in
I agree that separating the patches will make the review process easier.
I will prepare and send a patch series using `git format-patch` as you
suggested.
I have also attached a part of the PDF generated with both 0001 and
0002 applied for your reference.
Best regards,
Noboru Saito
2025年6月9日(月) 16:17 Hayato Kuroda (Fujitsu) <kuroda.hayato@fujitsu.com>:
>
> Dear Saito-san,
>
> > - A patch that adds margins to admonition blocks.
> > - An updated image where I have highlighted the space with a red
> > border for clarity.
> >
> > The image shows:
> > - The original layout (top left)
> > - Only indentation set to 0 (top right)
> > - Indentation 0 plus admonition margins (bottom right)
>
> To confirm, the top-right was generated with the previous patch, and bottom-right
> was generated v2 patch, right? I prefer the bottom-right one.
>
> BTW, I can suggest separating patches like:
>
> 0001 - setting both body.start.indent and body.end.indent to 0
> 0002 - set margin-left and margin-right to 0.25in
>
> This approach makes us easier to understand and discuss, i.e., someone only loves
> 0001. They can be combined by committers when they push changes.
> To create a series of patches, you can git format-patch command can be used.
> Please refer [1] for more detail.
>
>
> [1]: https://git-scm.com/book/en/v2/Appendix-C:-Git-Commands-Email
>
> Best regards,
> Hayato Kuroda
> FUJITSU LIMITED
>
