Re: Convert macros to static inline functions - Mailing list pgsql-hackers

From Amul Sul
Subject Re: Convert macros to static inline functions
Date
Msg-id CAAJ_b94K6AnB4rzp2rDbhEioR0a90iR+RvETxEr-GGSqrjMzTQ@mail.gmail.com
Whole thread Raw
In response to Re: Convert macros to static inline functions  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
Responses Re: Convert macros to static inline functions  (Peter Eisentraut <peter.eisentraut@enterprisedb.com>)
List pgsql-hackers
On Tue, Oct 4, 2022 at 12:00 PM Peter Eisentraut
<peter.eisentraut@enterprisedb.com> wrote:
>
> On 16.05.22 10:27, Peter Eisentraut wrote:
> > Inspired by [0], I looked to convert more macros to inline functions.
>
> Here is another one from the same batch of work that I somehow didn't
> send in last time.
>
I think assertion can be placed outside of the IF-block and braces can
be removed.

> (IMO it's questionable whether this one should be an inline function or
> macro at all, rather than a normal external function.)
IMO, it should be inlined with RelationGetSmgr().

Regards,
Amul



pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: GUC tables - use designated initializers
Next
From: Peter Smith
Date:
Subject: Re: GUC tables - use designated initializers