Re: Small doc improvement about spilled txn tracking - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Small doc improvement about spilled txn tracking
Date
Msg-id CAA4eK1LRiJoU4s_ECUX7tx6v2kLuMsT-jLjS+S5uDYNj0Q_zAw@mail.gmail.com
Whole thread Raw
In response to Re: Small doc improvement about spilled txn tracking  (Masahiko Sawada <masahiko.sawada@2ndquadrant.com>)
Responses Re: Small doc improvement about spilled txn tracking
List pgsql-hackers
On Tue, Jun 2, 2020 at 11:30 AM Masahiko Sawada
<masahiko.sawada@2ndquadrant.com> wrote:
>
> On Tue, 2 Jun 2020 at 14:50, Amit Kapila <amit.kapila16@gmail.com> wrote:
> >
> > On Tue, Jun 2, 2020 at 10:22 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > >
> > > On Tue, Jun 2, 2020 at 9:10 AM Masahiko Sawada
> > > <masahiko.sawada@2ndquadrant.com> wrote:
> > > >
> > >
> > > > Please find attached patch.
> > > >
> > >
> > > On a quick look, it seems fine but I will look in more detail and let
> > > you know if I have any feedback.
> > >
> >
> > I am not sure if we need to add "Logical decoding plugins may
> > optionally emit tracking message." as the stats behavior should be the
> > same for decoding plugin and logical replication.  Apart from removing
> > this line, I have made a few other minor changes, see what you think
> > of attached?
> >
>
> I'm okay with removing that sentence. The patch looks good to me.
>

Pushed.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com



pgsql-hackers by date:

Previous
From: Kyotaro Horiguchi
Date:
Subject: Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical() at walsender.c:2762
Next
From: Masahiko Sawada
Date:
Subject: Resetting spilled txn statistics in pg_stat_replication