Re: Small doc improvement about spilled txn tracking - Mailing list pgsql-hackers

From Masahiko Sawada
Subject Re: Small doc improvement about spilled txn tracking
Date
Msg-id CA+fd4k5EeujyYLnOSvb1wZLLYxpGbpjaVRQXmpAFRJ6yhsrAnw@mail.gmail.com
Whole thread Raw
In response to Re: Small doc improvement about spilled txn tracking  (Amit Kapila <amit.kapila16@gmail.com>)
List pgsql-hackers
On Tue, 2 Jun 2020 at 15:15, Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Tue, Jun 2, 2020 at 11:30 AM Masahiko Sawada
> <masahiko.sawada@2ndquadrant.com> wrote:
> >
> > On Tue, 2 Jun 2020 at 14:50, Amit Kapila <amit.kapila16@gmail.com> wrote:
> > >
> > > On Tue, Jun 2, 2020 at 10:22 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > >
> > > > On Tue, Jun 2, 2020 at 9:10 AM Masahiko Sawada
> > > > <masahiko.sawada@2ndquadrant.com> wrote:
> > > > >
> > > >
> > > > > Please find attached patch.
> > > > >
> > > >
> > > > On a quick look, it seems fine but I will look in more detail and let
> > > > you know if I have any feedback.
> > > >
> > >
> > > I am not sure if we need to add "Logical decoding plugins may
> > > optionally emit tracking message." as the stats behavior should be the
> > > same for decoding plugin and logical replication.  Apart from removing
> > > this line, I have made a few other minor changes, see what you think
> > > of attached?
> > >
> >
> > I'm okay with removing that sentence. The patch looks good to me.
> >
>
> Pushed.

Thank you!

Regards,

-- 
Masahiko Sawada            http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services



pgsql-hackers by date:

Previous
From: Masahiko Sawada
Date:
Subject: Resetting spilled txn statistics in pg_stat_replication
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Resetting spilled txn statistics in pg_stat_replication