Postgres Pro
Downloads
Home   >   mailing lists

Re: Reducing ClogControlLock contention - Mailing list pgsql-hackers

From Amit Kapila
Subject Re: Reducing ClogControlLock contention
Date
Msg-id CAA4eK1LJkAhn9uqejMXBNc+Dp-q-+ZEXnc0x=bzh-s3407A_Nw@mail.gmail.com
Whole thread Raw
In response to Re: Reducing ClogControlLock contention  (Simon Riggs <simon@2ndQuadrant.com>)
Responses Re: Reducing ClogControlLock contention  (Simon Riggs <simon@2ndQuadrant.com>)
List pgsql-hackers
Tree view
On Tue, Aug 25, 2015 at 2:21 PM, Simon Riggs <simon@2ndquadrant.com> wrote:
On 22 August 2015 at 15:14, Andres Freund <andres@anarazel.de> wrote:
 
TransactionIdSetPageStatus() calls TransactionIdSetStatusBit(), which
writes an 8 byte variable (the lsn). That's not safe.

Agreed, thanks for spotting that.

I see this as the biggest problem to overcome with this patch.

How about using 64bit atomics or spinlock to protect this variable?


With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

pgsql-hackers by date:

Previous
From: Etsuro Fujita
Date:
Subject: Re: Foreign join pushdown vs EvalPlanQual
Next
From: Simon Riggs
Date:
Subject: Re: Reducing ClogControlLock contention